fix: dispose creates inbound Call record, webhook enriches — eliminates UCID mismatch + timing race
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed

Root cause: CDR webhook fires 5s after dispose, stores monitorUCID.
Frontend has agent-side UCID from SIP. They never matched → disposition
not persisted, agent call history empty.

Fix:
- Dispose endpoint now creates Call records for ALL answered calls
  (inbound + outbound), not just outbound. Record gets agent-side UCID
  + correct disposition immediately.
- Webhook checks if Call record already exists (by agent UCID via
  monitorUCID→agentUCID mapping). If found, enriches with recording
  URL, agent chain name, CDR timing. If not found, creates as fallback.
- SupervisorService stores UCID mapping from real-time events (which
  carry both UCIDs). Auto-expires after 10 minutes.

Verified: UCID-MAP logged, dispose creates record, webhook enriches
without duplicating. DB shows correct agent UCID + disposition + recording.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-18 08:31:07 +05:30
parent 8c8b1e78b0
commit 3f22166ac0
3 changed files with 83 additions and 54 deletions

View File

@@ -156,11 +156,13 @@ export class OzonetelAgentController {
this.logger.error(`[DISPOSE] FAILED: ${message} ${responseData}`);
}
// Create call record for outbound calls. Inbound calls are
// created by the webhook — but we skip outbound in the webhook
// (they're not "missed calls"). So the dispose endpoint is the
// only place that creates the call record for outbound dials.
if (body.direction === 'OUTBOUND' && body.callerPhone) {
// Create call record at dispose time for ALL answered calls
// (inbound + outbound). The dispose endpoint fires BEFORE the
// CDR webhook, so creating here gives us the correct agent-side
// UCID and the agent's chosen disposition immediately. The webhook
// arrives ~5s later and enriches with recording URL + chain name.
if (body.callerPhone) {
const isInbound = body.direction !== 'OUTBOUND';
try {
const durationSec = body.durationSec ?? 0;
const endedAt = new Date().toISOString();
@@ -168,8 +170,8 @@ export class OzonetelAgentController {
? new Date(Date.now() - durationSec * 1000).toISOString()
: endedAt;
const callData: Record<string, any> = {
name: `Outbound — ${body.callerPhone}`,
direction: 'OUTBOUND',
name: isInbound ? `Inbound — ${body.callerPhone}` : `Outbound — ${body.callerPhone}`,
direction: isInbound ? 'INBOUND' : 'OUTBOUND',
callStatus: 'COMPLETED',
callerNumber: { primaryPhoneNumber: `+91${body.callerPhone.replace(/^\+?91/, '')}` },
agentName: agentId,
@@ -196,7 +198,7 @@ export class OzonetelAgentController {
{ data: callData },
`Bearer ${apiKey}`,
);
this.logger.log(`[DISPOSE] Created outbound call record: ${result.createCall.id}`);
this.logger.log(`[DISPOSE] Created ${isInbound ? 'inbound' : 'outbound'} call record: ${result.createCall.id} ucid=${body.ucid} disposition=${body.disposition} phone=${body.callerPhone}`);
// Fetch recording URL from CDR after a delay (Ozonetel needs time to process)
const callId = result.createCall.id;
@@ -278,33 +280,9 @@ export class OzonetelAgentController {
}
}
// Update disposition on answered inbound calls. The webhook creates
// the Call record with the Ozonetel default disposition ("General
// Enquiry" → INFO_PROVIDED) before the agent disposes. Now that the
// agent has submitted their actual disposition, write it back to the
// platform Call record by matching on UCID.
//
// Skipped for outbound (already created with correct disposition
// above) and for missed-call callbacks (handled in the block above).
if (!body.missedCallId && body.direction !== 'OUTBOUND' && body.ucid) {
try {
const callData = await this.platform.query<any>(
`{ calls(first: 1, filter: { ucid: { eq: "${body.ucid}" } }) { edges { node { id } } } }`,
);
const callId = callData?.calls?.edges?.[0]?.node?.id;
if (callId) {
await this.platform.query<any>(
`mutation($id: UUID!, $data: CallUpdateInput!) { updateCall(id: $id, data: $data) { id } }`,
{ id: callId, data: { disposition: body.disposition } },
);
this.logger.log(`[DISPOSE] Updated inbound call ${callId} disposition → ${body.disposition}`);
} else {
this.logger.warn(`[DISPOSE] No Call found for ucid=${body.ucid} — disposition not persisted`);
}
} catch (err: any) {
this.logger.warn(`[DISPOSE] Failed to update inbound call disposition: ${err.message}`);
}
}
// Inbound disposition is now handled by the call record creation
// above — the dispose endpoint creates the record with the correct
// disposition. No separate update-by-UCID needed.
// Auto-assign next missed call to this agent
try {