helix-admin/helix-engage-server
1
0
Fork 0
mirror of https://dev.azure.com/globalhealthx/EMR/_git/helix-engage-server synced 2026-05-18 20:08:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: stop auto-creating Unknown leads on caller resolve

Browse Source 
Return empty IDs for unrecognized numbers instead of creating lead+patient.
Per PRD: 'System will not identify the patient — no summary shown.'
Records are created when agent books appointment or logs enquiry.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
saridsa2
2026-04-13 11:23:22 +05:30
parent 5969441868
commit a4ff052fef
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/caller/caller-resolution.service.ts
View File

@@ -23,7 +23,12 @@ export class CallerResolutionService {
private readonly cache: SessionService, private readonly cache: SessionService,
) {} ) {}
// Resolve a caller by phone number. Always returns a paired lead + patient. // Resolve a caller by phone number.
// Looks up existing lead + patient by phone. If neither exists, returns
// isNew: true with no IDs — records are NOT created automatically.
// Record creation happens when the agent explicitly books an appointment
// or logs an enquiry (per PRD: "System will not identify the patient —
// no summary shown" for unregistered numbers).
async resolve(phone: string, auth: string): Promise<ResolvedCaller> { async resolve(phone: string, auth: string): Promise<ResolvedCaller> {
const normalized = phone.replace(/\D/g, '').slice(-10); const normalized = phone.replace(/\D/g, '').slice(-10);
if (normalized.length < 10) { if (normalized.length < 10) {
@@ -85,13 +90,12 @@ export class CallerResolutionService {
isNew: false, isNew: false,
}; };
} else { } else {
// Neither exists — create both // Neither exists — return empty result, don't create records.
const newPatient = await this.createPatient('', '', normalized, auth); // Agent will create records when they book an appointment or log an enquiry.
const newLead = await this.createLead('', '', normalized, newPatient.id, auth); this.logger.log(`[RESOLVE] No existing records for ${normalized} — returning unresolved`);
this.logger.log(`[RESOLVE] Created new lead ${newLead.id} + patient ${newPatient.id} for ${normalized}`);
result = { result = {
leadId: newLead.id, leadId: '',
patientId: newPatient.id, patientId: '',
firstName: '', firstName: '',
lastName: '', lastName: '',
phone: normalized, phone: normalized,