helix-admin/helix-engage
1
0
Fork 0
mirror of https://dev.azure.com/globalhealthx/EMR/_git/helix-engage synced 2026-04-12 02:38:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: pass data-icon prop through FontAwesome icon wrappers

Browse Source 
Replaced all bare `FC<{ className?: string }>` and `FC<HTMLAttributes<...>>`
wrappers that only forwarded `className` with `faIcon()` from
`src/lib/icon-wrapper.ts`, ensuring props like `data-icon` needed by the
Button component's CSS selector `*:data-icon:size-5` are correctly forwarded.
Also widened `NavItemBaseProps.icon` and `NavItemType.icon` prop types to
`FC<Record<string, any>>` to stay compatible with `faIcon()` return type.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
saridsa2
2026-03-21 11:19:46 +05:30
parent 2ace6efae5
commit 631acf63dc
11 changed files with 65 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/application/app-navigation/base-components/nav-item.tsx
View File

@@ -1,4 +1,4 @@
import type { FC, HTMLAttributes, MouseEventHandler, ReactNode } from "react";
import type { FC, MouseEventHandler, ReactNode } from "react";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { faChevronDown, faArrowUpRightFromSquare } from "@fortawesome/pro-duotone-svg-icons";
import { Link as AriaLink } from "react-aria-components";
@@ -20,7 +20,7 @@ interface NavItemBaseProps {
/** Type of the nav item. */
type: "link" | "collapsible" | "collapsible-child";
/** Icon component to display. */
icon?: FC<HTMLAttributes<HTMLOrSVGElement>>;
icon?: FC<Record<string, any>>;
/** Badge to display. */
badge?: ReactNode;
/** Whether the nav item is currently active. */

4
src/components/application/app-navigation/config.ts
View File

@@ -6,11 +6,11 @@ export type NavItemType = {
/** URL to navigate to when the nav item is clicked. */
href?: string;
/** Icon component to display. */
icon?: FC<{ className?: string }>;
icon?: FC<Record<string, any>>;
/** Badge to display. */
badge?: ReactNode;
/** List of sub-items to display. */
items?: { label: string; href: string; icon?: FC<{ className?: string }>; badge?: ReactNode }[];
items?: { label: string; href: string; icon?: FC<Record<string, any>>; badge?: ReactNode }[];
/** Whether this nav item is a divider. */
divider?: boolean;
};